ci: lock all kas repos #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndechesne
reviewed
Oct 11, 2024
quaresmajose
force-pushed
the
lock
branch
3 times, most recently
from
6110338 to
e2a211a
Compare
|
I think I will create another PR to refactor and merge the check-layer.yml in the build-yocto.yml since they are dependent on each other. |
|
Depends on #39 |
|
I think it is better if you can isolate just the lockfile related changes here, and do the rest in another pr (e.g. persistent dir, common root dir, etc). |
ndechesne
reviewed
Oct 14, 2024
I removed the other stuff and will propose it in PR #41 |
quaresmajose
force-pushed
the
lock
branch
2 times, most recently
from
0c4ed16 to
9a2eb54
Compare
|
I need to update the commit message since the implementation is already considerably different |
Merged
ndechesne
reviewed
Oct 15, 2024
This guarantees that the build job can be easily replicated later. The kas will generate a file named base.lock.yml which will later be used instead of base.yml, we will save the lock file in action artifact in order to be shared with other jobs. Reference: https://kas.readthedocs.io/en/latest/userguide/project-configuration.html#working-with-lockfiles Signed-off-by: Jose Quaresma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guarantees that the build job can be easily replicated later.
The kas will generate a file named base.lock.yml which will later
be used instead of base.yml, we will save the lock file in action
artifact in order to be shared with other jobs.
Reference:
https://kas.readthedocs.io/en/latest/userguide/project-configuration.html#working-with-lockfiles
Fixes #21