Kas persistent #63
Merged
Kas persistent #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndechesne
requested review from
quic-vkraleti,
ricardosalveti and
sbanerjee-quic
as code owners
quaresmajose
reviewed
Nov 6, 2024
Use a global env variable for the persistent storage to avoid duplication. This should really be a no-op change. Signed-off-by: Nicolas Dechesne <[email protected]>
This variable can be used to specify where to clone all repos used by kas. By setting up a persistent storage location, we can keep a copy of all git trees locally, and only fetch new objects. So kas will first clone/fetch objects in KAS_REPO_REF_DIR location, and then will use them as a source when checking out the repo for the build. The documentation says that: Multiple instances of kas can simultaneously work on the same directory, as long as the underlying filesystem is POSIX compatible. So it is designed to be safe in CI environments such as ours. New trees are cloned the first time they are encountered, and only new objects are fetched otherwise. Note: we cannot concatenate global env variables, hence a little bit of duplication between KAS_REPO_REF_DIR and CACHE_DIR. Signed-off-by: Nicolas Dechesne <[email protected]>
ndechesne
force-pushed
the
kas-persistent
branch
from
0066052 to
35a1a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is the 2nd one, where we clone all kas repos in our persistent storage to avoid cloning each time from upstream. This variable needed to be global so that it's used in all jobs (kas-dump, check-layer and compile) since they all today clone all repos from upstream.
Since I was adding global env variables, I also added one for the persistent folder, since it was used in 2 different places already.