Re-apply "expose ipFamily" #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 57b526f.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
I would like to be able to use this feature, but I unfortunately don't think I have the skills to fix what needs done for the tests, but if there is some way I can help I can try. |
|
@mikhailshilkov is there anything else that needs to be done other than a review? Happy to contribute if there is anything I can do. |
|
@mikhailshilkov Waiting for this since many years. Any ETA possible? AWS is now charing for IPV4 making this even more important: https://aws.amazon.com/blogs/aws/new-aws-public-ipv4-address-charge-public-ip-insights/ |
rquitales
added a commit
that referenced
this pull request
Mar 26, 2024
Fixes #698 Based on #888 and rebased onto master --------- Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]> Co-authored-by: Ramon Quitales <[email protected]>
rquitales
added a commit
that referenced
this pull request
Mar 27, 2024
Fixes #698 Based on #888 and rebased onto master --------- Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]> Co-authored-by: Ramon Quitales <[email protected]>
rquitales
added a commit
that referenced
this pull request
Mar 27, 2024
Fixes #698 Based on #888 and rebased onto master --------- Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]> Co-authored-by: Ramon Quitales <[email protected]>
rquitales
added a commit
that referenced
this pull request
Mar 29, 2024
### Proposed changes This PR exposes the `ipFamily` argument to enable creating EKS clusters that support ipv6 networking. Modified from #888 and rebased on top of latest changes in master. An additional cluster with ipv6 is also created to test that cluster creation works as expected. ### Related issues (optional) Closes: #698 Closes: #684 --------- Co-authored-by: David Roth <[email protected]> Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]>
|
Superseded by #1098 |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Proposed changes This PR exposes the `ipFamily` argument to enable creating EKS clusters that support ipv6 networking. Modified from #888 and rebased on top of latest changes in master. An additional cluster with ipv6 is also created to test that cluster creation works as expected. ### Related issues (optional) Closes: #698 Closes: #684 --------- Co-authored-by: David Roth <[email protected]> Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applies #882 to fix #698 but now with green build (eventually)