Expose Ip-Family for IPV6 (#1089) #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
adff652 to
37b1bdc
Compare
Fixes #698 Based on #888 and rebased onto master --------- Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]> Co-authored-by: Ramon Quitales <[email protected]>
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
37b1bdc to
cd23fed
Compare
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
cd23fed to
6f4a06f
Compare
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
6f4a06f to
f8098b7
Compare
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
f8098b7 to
ac33a32
Compare
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
2 times, most recently
from
582ee31 to
af28859
Compare
rquitales
force-pushed
the
rquitales/expose-ipv6
branch
from
af28859 to
708604b
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
@rquitales It looks like the acceptance tests have been successfully completed.🥳 |
EronWright
approved these changes
Mar 29, 2024
|
Note: this PR previously passed all pre-submits. A new commit was added that only modified comments (6c3675e), so I'll be force pushing it since retesting requires another 30-45 mins to run. We also have post-submit CI runs that also exercise the same tests. |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Proposed changes This PR exposes the `ipFamily` argument to enable creating EKS clusters that support ipv6 networking. Modified from #888 and rebased on top of latest changes in master. An additional cluster with ipv6 is also created to test that cluster creation works as expected. ### Related issues (optional) Closes: #698 Closes: #684 --------- Co-authored-by: David Roth <[email protected]> Co-authored-by: Mikhail Shilkov <[email protected]> Co-authored-by: Kyle Pitzen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR exposes the
ipFamilyargument to enable creating EKS clusters that support ipv6 networking.Modified from #888 and rebased on top of latest changes in master.
An additional cluster with ipv6 is also created to test that cluster creation works as expected.
Related issues (optional)
Closes: #698
Closes: #684