Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Ip-Family for IPV6 #1089

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Expose Ip-Family for IPV6 #1089

merged 4 commits into from
Mar 26, 2024

Conversation

davidroth
Copy link
Contributor

Fixes #698
Based on #888 and rebased onto master

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@davidroth
Copy link
Contributor Author

@mikhailshilkov I have rebased your MR on master and resolved the conflicts.
Really looking forward to finally get this into main 🙏

@rquitales
Copy link
Member

/run-acceptance-tests

@rquitales rquitales self-assigned this Mar 26, 2024
@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@rquitales rquitales mentioned this pull request Mar 26, 2024
Closed
@pulumi pulumi deleted a comment from github-actions bot Mar 26, 2024
@rquitales rquitales changed the base branch from master to rquitales/expose-ipv6 March 26, 2024 16:14
@rquitales
Copy link
Member

Due to a bug in our acceptance testing workflow, I'll be merging it into a feature branch and create another PR against master branch to get this in with CI tests. Thanks for kicking off the work on this and pushing this along @davidroth. I'll be sure to update you once we get this released!

@rquitales rquitales merged commit 70ac41a into pulumi:rquitales/expose-ipv6 Mar 26, 2024
11 checks passed
@rquitales rquitales mentioned this pull request Mar 26, 2024
Merged
rquitales added a commit that referenced this pull request Mar 27, 2024
@davidroth @mikhailshilkov
@kpitzen @rquitales
Expose Ip-Family for IPV6 (#1089)
80c011d 
Fixes #698
Based on #888 and rebased onto
master

---------

Co-authored-by: Mikhail Shilkov <[email protected]>
Co-authored-by: Kyle Pitzen <[email protected]>
Co-authored-by: Ramon Quitales <[email protected]>
rquitales added a commit that referenced this pull request Mar 27, 2024
@davidroth @mikhailshilkov
@kpitzen @rquitales
Expose Ip-Family for IPV6 (#1089)
635f7a1 
Fixes #698
Based on #888 and rebased onto
master

---------

Co-authored-by: Mikhail Shilkov <[email protected]>
Co-authored-by: Kyle Pitzen <[email protected]>
Co-authored-by: Ramon Quitales <[email protected]>
rquitales added a commit that referenced this pull request Mar 29, 2024
@rquitales @davidroth
@mikhailshilkov @kpitzen
Expose Ip-Family for IPV6 (#1089) (#1098)
e55b0c2 
### Proposed changes
This PR exposes the `ipFamily` argument to enable creating EKS clusters
that support ipv6 networking.
Modified from #888 and rebased
on top of latest changes in master.

An additional cluster with ipv6 is also created to test that cluster
creation works as expected.

### Related issues (optional)
Closes: #698
Closes: #684

---------

Co-authored-by: David Roth <[email protected]>
Co-authored-by: Mikhail Shilkov <[email protected]>
Co-authored-by: Kyle Pitzen <[email protected]>
flostadler pushed a commit that referenced this pull request Sep 4, 2024
@rquitales @davidroth
@mikhailshilkov @kpitzen
Expose Ip-Family for IPV6 (#1089) (#1098)
2e7ebfe 
### Proposed changes
This PR exposes the `ipFamily` argument to enable creating EKS clusters
that support ipv6 networking.
Modified from #888 and rebased
on top of latest changes in master.

An additional cluster with ipv6 is also created to test that cluster
creation works as expected.

### Related issues (optional)
Closes: #698
Closes: #684

---------

Co-authored-by: David Roth <[email protected]>
Co-authored-by: Mikhail Shilkov <[email protected]>
Co-authored-by: Kyle Pitzen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rquitales rquitales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ClusterKubernetesNetworkConfig-> ipFamily to support IPv6
4 participants
@davidroth @rquitales @mikhailshilkov @kpitzen