Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added admin user creation feature #39

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

abhi36
Copy link

@abhi36 abhi36 commented Feb 26, 2020

No description provided.

@pmill pmill mentioned this pull request Feb 27, 2020
README.md Outdated
0.2.11 (06/01/2020)

Added method to get a user by an access token - bjoernHeneka

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these changes? if this PR is merged, I'll need to update the date and version anyway so I'll add make these changes myself.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are still here in the diff.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder about this one.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is still here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it after interactive rebase to my branch. Not sure how it's still not getting updated. Those lines are even not showing in my codebase now

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's on this commit 745e545

src/CognitoClient.php Outdated Show resolved Hide resolved
src/CognitoClient.php Outdated Show resolved Hide resolved
src/CognitoClient.php Outdated Show resolved Hide resolved
@abhi36 abhi36 requested a review from pmill February 27, 2020 22:31
@pmill pmill changed the base branch from tests to master February 28, 2020 10:21
src/CognitoClient.php Outdated Show resolved Hide resolved
src/CognitoClient.php Outdated Show resolved Hide resolved
README.md Outdated
0.2.11 (06/01/2020)

Added method to get a user by an access token - bjoernHeneka

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are still here in the diff.

src/CognitoClient.php Outdated Show resolved Hide resolved
src/CognitoClient.php Outdated Show resolved Hide resolved
@abhi36 abhi36 requested a review from pmill February 28, 2020 19:03
src/CognitoClient.php Outdated Show resolved Hide resolved
src/CognitoClient.php Outdated Show resolved Hide resolved
README.md Outdated
0.2.11 (06/01/2020)

Added method to get a user by an access token - bjoernHeneka

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder about this one.

@abhi36 abhi36 requested a review from pmill March 17, 2020 17:46
@abhi36
Copy link
Author

abhi36 commented Apr 1, 2020

@pmill Are everything fine now with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants