-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added admin user creation feature #39
Open
abhi36
wants to merge
16
commits into
pmill:master
Choose a base branch
from
abhi36:dev-ak
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0ffaee5
Added Exception for invalidParameter & NotAuthorized
abhi36 2b674d1
Added InvalidParameter & NotAuthorized exceptions
abhi36 ac98fdd
Added method to create a user by admin and set the status to CONFIRMED
abhi36 745e545
Merge remote-tracking branch 'origin/master' into dev-ak
abhi36 7ad0bd2
Create group if the same is missing while trying to add a user to the…
abhi36 e48c3a4
Rebasing repo
abhi36 72a169e
Rebasing
abhi36 53f9bc5
Removing non-required exception classes
abhi36 50207bc
Separated user cofirmation from user creation
abhi36 f0ccae2
Added admin method to create user group
abhi36 4fd8a25
Updated user attributes acceptance format for user creation
abhi36 89b7233
Making requested changes from fixes #39
abhi36 2e27bac
Removed admin confirmation method for admin added users
abhi36 6274d88
Fixing code formatting
abhi36 4856d00
Adding method to chage a user password
abhi36 11eccee
Method to remove a user from a group
abhi36 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these changes? if this PR is merged, I'll need to update the date and version anyway so I'll add make these changes myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are still here in the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder about this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is still here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it after interactive rebase to my branch. Not sure how it's still not getting updated. Those lines are even not showing in my codebase now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's on this commit 745e545