-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin user creation method #38
Conversation
Add missing php on README.md
Adds method to retrieve User by an accessToken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abhi36, thanks for your PR, just a few changes please.
The PR title doesn't seem to relate to the changes made, can you update it?
Also can you rebase your branch? There are a few commits in there that don't look related.
0.2.11 (06/01/2020) | ||
|
||
Added method to get a user by an access token - bjoernHeneka | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format this like the other lines (indented and link your username)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this has bjoernHeneka's username, please change that to your own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmill Could you please give me access to push my branch? My this merge request can be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just need to push to your own branch on your fork and the PR will be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks & done :)
echo $user['Username'].PHP_EOL; | ||
var_dump($user['UserAttributes']); | ||
} catch (Exception $e) { | ||
echo "An error occurred: ".$e->getMessage(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a space before and after the .
? Same for the echo
line above
Add compatibility with cognito id tokens generated by hosted UI
Closing this as you seem to have replaced it with #39 |
Adding method to create a user using AdminCreateUser