update: skip scroll to top on inital SSR completion. #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
Signed-off-by: Faakhir30 <[email protected]>
Faakhir30
force-pushed
the
fix_scrollToTop_SSR
branch
from
462323f to
e698d56
Compare
stevepiercy
approved these changes
Dec 8, 2024
stevepiercy
added
24 status: ready
32 needs: review
99 tag: UX Accessibility
stevepiercy
requested changes
Dec 8, 2024
stevepiercy
requested review from
ichim-david,
tisto,
JeffersonBledsoe,
jackahl and
Wagner3UB
avoinea
requested changes
Dec 9, 2024
davisagli
requested changes
Dec 10, 2024
davisagli
approved these changes
Dec 10, 2024
9 tasks
sneridagh
added a commit
that referenced
this pull request
Dec 12, 2024
* main: Fixed types declaration extractor from Volto core, re-enable it on release (#6534) Release 18.3.0 Release @plone/slate 18.0.4 Release @plone/helpers 1.0.0 Make helpers release-able Release @plone/registry 2.2.0 Release @plone/components 3.0.0 Release @plone/types 1.1.0 [slots] @plone/slots first developments (#6409) improve link integrity popup (#6516) Add missing styleWrapper style builder information in container/Grid (#6527) update: skip scroll to top on inital SSR completion. (#6523) Release 18.2.3 Fixed circular import error in dev with HMR in core Views and Widgets shadow customizations (#6526) Release 18.2.2 Fixed circular import error in dev with HMR in core Blocks shadow customizations (#6525) Release 18.2.1 Release @plone/slate 18.0.3 Fixed circular import error in dev with HMR in `App` component when imported in the main default config (#6524) Update @plone/* packages info (#6521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6518 , skipping scroll to top on first
componenetDidUpdateafter SSR, as that is being triggered by SSR completion and is causing that intruption