Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent ScrollToTop from interrupting initial load scrolling #6519

Conversation

CoyoteClear340
Copy link

@CoyoteClear340 CoyoteClear340 commented Dec 7, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

@mister-roboto
Copy link

JD the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them.

Add more emails to your GitHub account:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Change the email address in your commits:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 79399ba
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/675400556aac7c00085e08a5

@fredvd
Copy link
Member

fredvd commented Dec 7, 2024

Hi @CoyoteClear340 Thanks for your contribution. I was checking the PR's for another issue I remember someone mentionned, but I also have some issues with certain page loads where the vertical scroll offset is stuck, so this spiked my interest.

when 'joining' online, the secretary will process your contributor agreement within 1-2 days, do you remember when you sent it in (digitally)?

Also: we use a tool to collect changes in separate file to avoid merge conflicts in the main changelog. If you can put a 6519.bugfix text file in the /packages/volto/news directory (the number can be from the PR, or origial issue) with a short description, that will be inserted in toe the Changelog.

@sneridagh and/or someone else from the Volto team or core developers will look at the technical contents of your PR, I'm not qualified enough yet for that part ;-)

If you have any other questions, let me know.

@davisagli
Copy link
Member

This was fixed in the meantime in #6523

@CoyoteClear340 Thanks for working on it anyway. In the future, make sure you say "Fixes #6523" in the PR description. It creates a link from the issue which makes it more obvious that someone is working on it.

@davisagli davisagli closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants