Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: skip scroll to top on inital SSR completion. #6523

Merged
merged 4 commits into from
Dec 10, 2024
Merged

update: skip scroll to top on inital SSR completion. #6523

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e698d56
added news.
Faakhir30 Dec 8, 2024
0c34913
update: ssr detection logic and news filename.
Faakhir30 Dec 9, 2024
efa614d
Merge branch 'main' into fix_scrollToTop_SSR
Faakhir30 Dec 9, 2024
292f75c
use prevProps instead of component state
Faakhir30 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/volto/news/6523.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disable initial scroll to top after SSR completion. @Faakhir30
9 changes: 9 additions & 0 deletions packages/volto/src/helpers/ScrollToTop/ScrollToTop.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,21 @@ class ScrollToTop extends React.Component {
children: PropTypes.node.isRequired,
};

state = {
isFirstClientUpdatePending: true,
};
/**
* @param {*} prevProps Previous Props
* @returns {null} Null
* @memberof ScrollToTop
*/
componentDidUpdate(prevProps) {
// Skip the first client-side update that happens right after hydration
if (this.state.isFirstClientUpdatePending) {
this.setState({ isFirstClientUpdatePending: false });
return;
}

Faakhir30 marked this conversation as resolved.
Show resolved Hide resolved
const { location } = this.props;
const noInitialBlocksFocus = // Do not scroll on /edit
config.blocks?.initialBlocksFocus === null
Expand Down
Loading