Clean up documentation, build system and compile warnings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested-by: editors and git
The apt command is the newer interactive package manager for APT.
It isn't used, only libncursesw5-dev is used.
…dency libncursesw5-dev is from an obsolete version of ncurses.
The default install path is only writable by root.
This is one less command to copy and run.
Link to the Repology service to list the versions and use the SVG badges provided by Repology for a local list.
This prevents network attackers from manipulating transferred data. Suggested-by: check-all-the-things
This lets distros apply extra hardening flags, while keeping the supplied C++ build flags.
It does not appear to be used. Fixes: otakuto#27
The executable should not be in /usr/sbin as that is for packages only. Using GNUInstallDirs gives the right dir by default and allows distros to install into /usr/sbin when they want. Fixes: otakuto#29
Otherwise the string itself could be interpreted as a format string. Suggested-by: g++
Suggested-by: g++
…uint64_t value This is more portable as it will use the right constant for each platform. Suggested-by: g++
The sa_handler member is the first member on most platforms but is not the first on MIPS. Fixes: https://bugs.debian.org/987829
|
This looks good and fixes building from source for me. Any chance it can get merged? |
|
@otakuto if you would prefer I split this up into different pull
requests or if any changes are needed, please let me know.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
13 tasks
asimpson
added a commit
to asimpson/nixpkgs
that referenced
this pull request
Jan 16, 2023
This currently builds against a [PR][1] that fixes some cmake errors. I will submit a PR to build against the main branch once that PR is merged. [1]: otakuto/crazydiskinfo#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compile warnings with format strings.
Fixes the cmake build system flags and install location.
Updates the documentation.