crazydiskinfo: init at version 1.1.0

[asimpson]

Description of changes

crazydiskinfo provides a TUI that surfaces smart data and uses Crystal Disk Info's algorithm for disk health and temperatures.

This currently builds against a PR that fixes some cmake errors. I will submit a PR to build against the main branch once that PR is merged.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[tejing1]

• It's considered proper to add yourself to the maintainers list in a separate commit before adding the package
• If you replace a phase, make sure to runHook the pre and post phase hooks in your replacement
• Are all of these tweaks necessary? That configure phase is pretty suspect at a glance. Won't that build the project? The build should be in the build phase.

[tejing1]

diff --git a/pkgs/applications/misc/crazydiskinfo/default.nix b/pkgs/applications/misc/crazydiskinfo/default.nix
index 562e79d3f4a..a94194ca6e8 100644
--- a/pkgs/applications/misc/crazydiskinfo/default.nix
+++ b/pkgs/applications/misc/crazydiskinfo/default.nix
@@ -15,14 +15,6 @@ stdenv.mkDerivation rec {
 
   buildInputs = [ ncurses libatasmart ];
 
-  configurePhase = ''
-    mkdir build
-    cd build
-    cmake ..
-  '';
-
-  installPhase = "install -D crazy $out/bin/crazy";
-
   meta = with lib; {
     description = "crazydiskinfo provides a TUI that surfaces smart data and uses Crystal Disk Info's algorithm for disk health and temperatures.";
     homepage = "https://github.com/otakuto/crazydiskinfo";

Works just fine for me.

[tejing1]

Complete silence from upstream for almost 3 years is also somewhat concerning. I'm not sure if that matters in terms of adding it to nixpkgs so long as it builds and runs fine, but I think we should at least consider the likelihood of that PR never getting merged.

[asimpson]

@tejing1 fair enough, I'll close the PR. If folks are curious about the package they can refer to this discussion. Thanks for the review!