Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up documentation, build system and compile warnings #33

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Clean up documentation, build system and compile warnings #33

wants to merge 15 commits into from

Commits on Nov 25, 2021

  1. Remove spaces at the end of lines 

    Suggested-by: editors and git
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    93fe2ed View commit details
    Browse the repository at this point in the history

  2. Switch from apt-get to apt for installing Debian packages 

    The apt command is the newer interactive package manager for APT.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    33f2c70 View commit details
    Browse the repository at this point in the history

  3. Remove libncurses5-dev Debian build dependency 

    It isn't used, only libncursesw5-dev is used.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d9480c0 View commit details
    Browse the repository at this point in the history

  4. Switch from libncursesw5-dev to libncurses-dev for Debian build depen… 

    …dency

libncursesw5-dev is from an obsolete version of ncurses.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    44e6b0d View commit details
    Browse the repository at this point in the history

  5. Use sudo when installing 

    The default install path is only writable by root.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    5a50b26 View commit details
    Browse the repository at this point in the history

  6. Use cmake to create the build directory 

    This is one less command to copy and run.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    34ba626 View commit details
    Browse the repository at this point in the history

  7. Add information about CrazyDiskInfo in distributions 

    Link to the Repology service to list the versions and
use the SVG badges provided by Repology for a local list.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c128c4e View commit details
    Browse the repository at this point in the history

  8. Switch URLs from http to https 

    This prevents network attackers from manipulating transferred data.

Suggested-by: check-all-the-things
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7ab1797 View commit details
    Browse the repository at this point in the history

  9. Preserve C++ build flags passed to cmake 

    This lets distros apply extra hardening flags,
while keeping the supplied C++ build flags.
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6464455 View commit details
    Browse the repository at this point in the history

  10. Don't link against tinfow 

    It does not appear to be used.

Fixes: otakuto#27
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7575c58 View commit details
    Browse the repository at this point in the history

  11. Install executable using GNUInstallDirs and CMAKE_INSTALL_SBINDIR 

    The executable should not be in /usr/sbin as that is for packages only.

Using GNUInstallDirs gives the right dir by default and
allows distros to install into /usr/sbin when they want.

Fixes: otakuto#29
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    320c159 View commit details
    Browse the repository at this point in the history

  12. Format strings: use %s when printing strings 

    Otherwise the string itself could be interpreted as a format string.

Suggested-by: g++
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    30ee4cd View commit details
    Browse the repository at this point in the history

  13. Format strings: get individual value of a std::pair 

    Suggested-by: g++
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    277f398 View commit details
    Browse the repository at this point in the history

  14. Format strings: use macro instead of format constant when printing a … 

    …uint64_t value

This is more portable as it will use the right constant for each platform.

Suggested-by: g++
    @pabs3
    pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e1ac1fa View commit details
    Browse the repository at this point in the history

  15. Initialise sigaction separately to sa_handler member 

    The sa_handler member is the first member on most
platforms but is not the first on MIPS.

Fixes: https://bugs.debian.org/987829
    @yangfl @pabs3
    yangfl authored and pabs3 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8563aa8 View commit details
    Browse the repository at this point in the history