-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: MoSDeF-dihedral-fit: A lightweight software for fitting dihedrals within MoSDeF #6970
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: 🟡 License found: |
Review checklist for @naik-aakashConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @RiesBenConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks @naik-aakash and @RiesBen for getting your reviews started! I see there's lots of activity also on the side of the authors in the respective issues, but please send us an note here when you have completed your updates or if any questions come up @jpotoff, thanks. |
Hi @jpotoff just checking in. When you have a moment, could you please let us know the status of addressing the reviewers' comments? Thank you. |
@phibeck We have addressed all of the reviewers comments and are good to go! |
@editorialbot generate pdf |
Hi @jpotoff thank you for letting us know you've completed working through the reviewers' comments. 🎉 I saw your change to the authorlist (#131), which does not seem to be reflected in the latest proof. Could you cross-check that please? Thanks. @RiesBen I see you've completed your checklist, thank you! 🎉 Could you please confirm that you agree to the publication of this software in its current form? |
Hi @phibeck, Thanks. I forgot to update the checklist. I have just a few things left to go through the changes. I will try to wrap it up by the end of this week and update you here. |
@editorialbot set 10.5281/zenodo.14271075 as archive |
Done! archive is now 10.5281/zenodo.14271075 |
@editorialbot set 0.1.12 as version |
Done! version is now 0.1.12 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6214, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
I'm sorry @bc118, I'm afraid I can't do that. That's something only eics are allowed to do. |
@phibeck This version looks good to me! |
Hi @jpotoff, in the paper, can the equations be moved to where they are actually mentioned in the text, rather than grouped together at the end (without the appropriate context)? It also appears that they have some unnecessary linebreaks, and are missing appropriate |
@kyleniemeyer @jpotoff @phibeck I have made the additional changes that were suggested by @kyleniemeyer above. It is now updated to version zenodo DOI for version |
@bc118 ah, changes to the paper only don't actually require updating the version / archives, if the software didn't change. But that's fine. |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @jpotoff @bc118 on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @naik-aakash and @RiesBen for reviewing this, and @phibeck for editing it. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jpotoff (Jeffrey Potoff)
Repository: https://github.com/GOMC-WSU/MoSDeF-dihedral-fit/
Branch with paper.md (empty if default branch):
Version: 0.1.12
Editor: @phibeck
Reviewers: @naik-aakash, @RiesBen
Archive: 10.5281/zenodo.14271075
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@naik-aakash & @RiesBen, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @phibeck know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @naik-aakash
📝 Checklist for @RiesBen
The text was updated successfully, but these errors were encountered: