Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions : Documentation and Tests #99

Closed
naik-aakash opened this issue Jul 20, 2024 · 2 comments
Closed

Suggestions : Documentation and Tests #99

naik-aakash opened this issue Jul 20, 2024 · 2 comments

Comments

@naik-aakash
Copy link

Part of JOSS review : openjournals/joss-reviews#6970

Dear developers,

Do not know how much of additional work it can be. I was thinking would it be feasible to add some examples for dihedral fitting using other forcefields i.e., CHARMM, TraPPE, AMBER, Mie, and Exp6 to the documentation ?

And also include some tests for these. I noticed MIE and OPLS are already included in tests, but could not find tests for other forcefields mentioned in the paper. (It is possible I could be missed the tests, kindly correct me if am mistaken on this.)

@bc118
Copy link
Collaborator

bc118 commented Jul 21, 2024

Hello!

Thank you for your review and comments! We will complete all of these that are feasible to completed. We started a issue checklist with all the reviewer comments, so we can address them and write our teams notes here #101.

If we need any clarifications, we will kindly ask for them. Thank you!

@daico007
Copy link
Collaborator

Addressed in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants