Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any previous works? #94

Closed
naik-aakash opened this issue Jul 20, 2024 · 6 comments
Closed

Any previous works? #94

naik-aakash opened this issue Jul 20, 2024 · 6 comments

Comments

@naik-aakash
Copy link

Part of JOSS review : openjournals/joss-reviews#6970

Dear developers,

I was reading through the paper submitted on the JOSS. There was this particular line that got me wondering if there are any previous studies that highlights this specific issue mentioned?

Due to these limitations, scientists assumed that the dihedral fits were transferable with all the atom classes in the dihedral fit; however, this is not always an accurate assumption. Some of the dihedrals were only fit to the first minimum and not the entire dihedral landscape, which can lead to errors in the predicted molecular conformations.

@jpotoff
Copy link
Collaborator

jpotoff commented Oct 2, 2024

We have decided to resolve this issue by deleting the paragraph at line number 74. While this is a known phenomena in the field, once getting into the literature it was clear there isn't a neat way of doing this well within the limited space of the article.

@bc118 bc118 closed this as completed Oct 5, 2024
@bc118 bc118 reopened this Oct 5, 2024
@bc118
Copy link
Collaborator

bc118 commented Oct 10, 2024

@naik-aakash Hello! All these tasks are completed. Additional information on each task is provided on an issue created for the JOSS review, which is Issue #101

https://github.com/GOMC-WSU/GOMC_Examples/tree/main/MoSDeF-dihedral-fit

@bc118 bc118 closed this as completed Oct 10, 2024
@bc118
Copy link
Collaborator

bc118 commented Oct 11, 2024

@naik-aakash

A new mosdef-dihedral-fit version 0.1.0 was released on GitHub and conda-forge, which contains all the review requests. Additionally, new examples are listed on the README file and are posted here

@naik-aakash
Copy link
Author

Thanks @bc118 will try to have a look asap in next days 😄

@bc118
Copy link
Collaborator

bc118 commented Oct 12, 2024

Ok, thanks! 🙏

@bc118
Copy link
Collaborator

bc118 commented Oct 13, 2024

@naik-aakash Please be aware of this minor change which we would like to fix for the paper, which will be reflected in the MoSDeF-dihedral-fit version 0.1.1. This was an oversight in the equally contributing tag in the authorship. #131

The person who had the equally contributing tag n the authorship removed is the one who submitted it, and I believe he will bring it up with the editor also, and is agreement with this change.

There is no change to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants