-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion : Tests #98
Comments
Hi @naik-aakash, I have added more tests specifically on the exceptions raised in our main code in #106 and #120. Please let us know if you think if there's any area that we missed and needed more testing. |
I will add that some of the missing coverage parts in code that I write come from “catch all” checks; in which case, I do not know how the code would end up in that error or warning. However, if someone makes an error in the code, something that changes in in unexpected ways or allows the user to enter problematic options, it may catch some of these conditions. |
Closing as reviewer provided thumbs up on the added tests and general “catch all” checks that are hard to replicate. More notes on this and other Reviewer Requests (provided as Issues) are located here #101 |
Part of JOSS review : openjournals/joss-reviews#6970
Dear developers,
I feel it would be great if tests are added to check for exceptions raised as well. From the current coverage report , I see most of the missing lines are from exceptions and would be better to have tests for these lines as well.
The text was updated successfully, but these errors were encountered: