-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Copulas.jl: A fully Distributions.jl-compliant copula package #6189
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @lucaferrantiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @AnderGray, could you please update us on how it's going with your review? |
Hi @osorensen and @lrnv 👋 , overall very nice work and I definitely recommend acceptance, here are some comments. PaperOverall the paper is clear and gives a good motivation to the package.
it is not clear to me from tha paper alone that DocumentationOverall the API is well documented and gives a lot of background knowledge. A few improvement suggestions
TyposI spotted a few typos, you may consider using a tool like typos-cli to check more systematically. This could also be setup on CI (actually the julia repo does it) but it might be an overkill.
UnicodeThe paper has some issues rendering some unicode characters |
@lucaferranti Thanks a lot for your time and your review. I definitely agree with all the points you mentioned, 100%. I will split your review into issues on Copulas.jl to be able to start working on each of them with my co-author @Santymax98. @osorensen it might take a while, but I think it is definitely worth it. |
@editorialbot generate pdf |
@editorialbot generate pdf |
@osorensen @lrnv Hi 👋 you can expect my review this week. Overall, looks good |
Review checklist for @AnderGrayConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Editorial comment on [JOSS submission](openjournals/joss-reviews#6189)
@AnderGray Maybe you could help with lrnv/Copulas.jl#176 ? |
@editorialbot set v0.1.21 as version |
Done! version is now v0.1.21 |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@lrnv, can you now please complete these tasks?
|
So :
|
@editorialbot set 10.5281/zenodo.6652672 as archive |
Done! archive is now 10.5281/zenodo.6652672 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5048, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
…182) * Create CITATION.cff From Joss openjournals/joss-reviews#6189 (comment) * Update CITATION.bib * Update README.md * Update index.md
Thanks a lot to @osorensen , @lucaferranti and @AnderGray for this review, the package and its documentation LARGELY improved from the comments and remarks that you brought tot he table, and we still have very good projects for further improvements thanks to @AnderGray. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @lrnv (Oskar Laverny)
Repository: https://github.com/lrnv/Copulas.jl
Branch with paper.md (empty if default branch):
Version: v0.1.21
Editor: @osorensen
Reviewers: @lucaferranti, @AnderGray
Archive: 10.5281/zenodo.6652672
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lucaferranti & @AnderGray, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @lucaferranti
📝 Checklist for @AnderGray
The text was updated successfully, but these errors were encountered: