Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paper] Add comparison table with BivariateCopulas.jl and DatagenCopulaBased.jl #116

Closed
Tracked by #114
lrnv opened this issue Feb 4, 2024 · 0 comments · Fixed by #127
Closed
Tracked by #114

[Paper] Add comparison table with BivariateCopulas.jl and DatagenCopulaBased.jl #116

lrnv opened this issue Feb 4, 2024 · 0 comments · Fixed by #127
Labels
JOSS

Comments

@lrnv
Copy link
Owner

lrnv commented Feb 4, 2024 •
edited
Loading

Link to JOSS review : openjournals/joss-reviews#6189

Lucas wrote:

At line 40 a pretty strong statement is made

Copulas.jl is clearly the must fully featured, and brings, as a key feature, the complience with the broader ecosystem.

It is not clear to me from the paper alone that Copulas.jl is the most feature complete of the three and would be good to give some more arguments in the paper.

Ideally, a table comparing features of the three would be nice to have.

I agree that a simple table comparing key functionalities would be usefull. We have to decide what to include in that table.
@lrnv lrnv mentioned this issue Feb 4, 2024
Closed
27 tasks
@lrnv lrnv added the JOSS label Feb 4, 2024
@lrnv lrnv changed the title At line 40 a pretty strong statement is made "Copulas.jl is clearly the must fully featured, and brings, as a key feature, the complience with the broader ecosystem." it is not clear to me from tha paper alone that Copulas.jl is the most feature complete of the three and would be good to give some more arguments in the paper. Ideally, a table comparing features of the three would be nice to have. Give argument on feature completion between the three. Feb 4, 2024
@lrnv lrnv changed the title Give argument on feature completion between the three. [Paper] Give argument on feature completion between the three Feb 4, 2024
@lrnv lrnv changed the title [Paper] Give argument on feature completion between the three [Paper] Add comparison table with BivariateCopulas.jl and DatagenCopulaBased.jl Feb 5, 2024
@lrnv lrnv mentioned this issue Feb 7, 2024
Merged
@lrnv lrnv linked a pull request Feb 7, 2024 that will close this issue
[Paper] add comparison tables and benchmark #127
Merged
@lrnv lrnv closed this as completed in #127 Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JOSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Paper] add comparison tables and benchmark Santymax98/Copulas.jl
1 participant
@lrnv