Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the filters to Created after #2990

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Jul 10, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-2701

Description

Changed the filter text of ExperimentTable, CompareRunTable, ManageRunTable and RunTable toolbar to Created after

Screenshot 2024-07-12 at 2 00 14 PM Screenshot 2024-07-12 at 2 01 22 PM Screenshot 2024-07-12 at 2 01 32 PM Screenshot 2024-07-12 at 2 01 07 PM

How Has This Been Tested?

  1. Manually checking ExperimentTable, CompareRunTable, ManageRunTable and RunTable toolbar in the the UI
  2. Check whether Started/Created is replaced by Created after

Test Impact

Updated the existing cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 requested a review from Gkrumbach07 July 10, 2024 11:10
@openshift-ci openshift-ci bot requested review from alexcreasy and ppadti July 10, 2024 11:11
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnaik1 Screenshots please

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Checked the screens mentioned. Can see "Created after" in the screens.

Screenshot 2024-07-11 at 7 22 32 PM Screenshot 2024-07-11 at 7 20 54 PM Screenshot 2024-07-11 at 7 21 32 PM

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit facf815 into opendatahub-io:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants