Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the filters to Created after #2990

Merged
merged 1 commit into from
Jul 12, 2024
Merged

changed the filters to Created after #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineRuns.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ describe('Pipeline runs', () => {
activeRunsTable.getRowByName('Test active run 3').find().should('exist');
});

it('filter by started', () => {
it('filter by created after', () => {
pipelineRunsGlobal.visit(projectName, pipelineId, pipelineVersionId, 'active');

// Verify initial run rows exist
Expand All @@ -443,7 +443,7 @@ describe('Pipeline runs', () => {
// Select the "Started" filter, select a value to filter by
pipelineRunsGlobal
.findActiveRunsToolbar()
.within(() => pipelineRunsGlobal.selectFilterByName('Started'));
.within(() => pipelineRunsGlobal.selectFilterByName('Created after'));

// Mock runs (filtered by start date), type a start date
activeRunsTable.mockGetActiveRuns(
Expand Down Expand Up @@ -662,14 +662,14 @@ describe('Pipeline runs', () => {
archivedRunsTable.getRowByName('Test archived run 2').find().should('exist');
});

it('filter by started', () => {
it('filter by created after', () => {
// Verify initial run rows exist
archivedRunsTable.findRows().should('have.length', 2);

// Select the "Started" filter, select a value to filter by
pipelineRunsGlobal
.findArchivedRunsToolbar()
.within(() => pipelineRunsGlobal.selectFilterByName('Started'));
.within(() => pipelineRunsGlobal.selectFilterByName('Created after'));

// Mock runs (filtered by start date), type a start date
archivedRunsTable.mockGetArchivedRuns(
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/pipelines/content/compareRuns/CompareRunTableToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const CompareRunTableToolbar: React.FC<FilterProps> = ({ ...toolbarProps }) => {
[FilterOptions.NAME]: 'Run',
[FilterOptions.EXPERIMENT]: 'Experiment',
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}),
[],
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import CreateExperimentButton from '~/concepts/pipelines/content/experiment/Crea

const options = {
[FilterOptions.NAME]: 'Experiment',
[FilterOptions.CREATED_AT]: 'Created',
[FilterOptions.CREATED_AT]: 'Created after',
};

export type FilterProps = Pick<
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const PipelineRunTableToolbar: React.FC<PipelineRunTableToolbarProps> = ({
...(!pipelineVersionId && {
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
}),
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}),
[experimentId, isExperimentsAvailable, pipelineVersionId],
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/pipelines/global/experiments/compareRuns/ManageRunsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const ManageRunsTable: React.FC<ManageRunsTableProps> = ({
[FilterOptions.NAME]: 'Run',
[FilterOptions.EXPERIMENT]: 'Experiment',
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}}
{...filterProps}
Expand Down
Loading