Skip to content

Commit

Permalink
changed the filters to Created after
Browse files Browse the repository at this point in the history
  • Loading branch information
pnaik1 committed Jul 10, 2024
1 parent 3e07400 commit d4f17fd
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ describe('Pipeline runs', () => {
activeRunsTable.getRowByName('Test active run 3').find().should('exist');
});

it('filter by started', () => {
it('filter by created after', () => {
pipelineRunsGlobal.visit(projectName, pipelineId, pipelineVersionId, 'active');

// Verify initial run rows exist
Expand All @@ -443,7 +443,7 @@ describe('Pipeline runs', () => {
// Select the "Started" filter, select a value to filter by
pipelineRunsGlobal
.findActiveRunsToolbar()
.within(() => pipelineRunsGlobal.selectFilterByName('Started'));
.within(() => pipelineRunsGlobal.selectFilterByName('Created after'));

// Mock runs (filtered by start date), type a start date
activeRunsTable.mockGetActiveRuns(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const CompareRunTableToolbar: React.FC<FilterProps> = ({ ...toolbarProps }) => {
[FilterOptions.NAME]: 'Run',
[FilterOptions.EXPERIMENT]: 'Experiment',
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}),
[],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import CreateExperimentButton from '~/concepts/pipelines/content/experiment/Crea

const options = {
[FilterOptions.NAME]: 'Experiment',
[FilterOptions.CREATED_AT]: 'Created',
[FilterOptions.CREATED_AT]: 'Created after',
};

export type FilterProps = Pick<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const PipelineRunTableToolbar: React.FC<PipelineRunTableToolbarProps> = ({
...(!pipelineVersionId && {
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
}),
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}),
[experimentId, isExperimentsAvailable, pipelineVersionId],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const ManageRunsTable: React.FC<ManageRunsTableProps> = ({
[FilterOptions.NAME]: 'Run',
[FilterOptions.EXPERIMENT]: 'Experiment',
[FilterOptions.PIPELINE_VERSION]: 'Pipeline version',
[FilterOptions.CREATED_AT]: 'Started',
[FilterOptions.CREATED_AT]: 'Created after',
[FilterOptions.STATUS]: 'Status',
}}
{...filterProps}
Expand Down

0 comments on commit d4f17fd

Please sign in to comment.