Drop dependency on gemma-zds-client #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4059 +/- ##
=======================================
Coverage 96.07% 96.08%
=======================================
Files 728 729 +1
Lines 22892 22917 +25
Branches 2659 2662 +3
=======================================
+ Hits 21994 22020 +26
Misses 636 636
+ Partials 262 261 -1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
from
e89d855 to
bc38084
Compare
sergei-maertens
commented
Mar 26, 2024
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
from
bc38084 to
b53be20
Compare
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
2 times, most recently
from
381ed39 to
b27de95
Compare
Configuration of the fields (defaults) from zgw api group needs to be stored on the registration backend options so that it's made explicit.
From zgw api group instance to form backend configuration, making the fields explicit.
Instead, make the fields required on the options serializer, ensuring they're specified for each registration backend. The previous commit handles the data migration for the instances without explicit configuration.
Dropping gemma-zds-client means that we can't use any of its API anymore.
Which drops gemma-zds-client as dependency.
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
from
b27de95 to
11a645a
Compare
The import was a left-over import that didn't have any effect.
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
from
4296951 to
19b6158
Compare
So that this can be used in VCR tests.
|
Test failures:
|
Discussed with the team on Slack, extensive input validation where relations between configuration aspects are verified for consistency and integrity is required, but only during configuration of the form. At registration time itself, only the validations that don't touch external services are performed, so that: * tests are simpler to write without having to set up mocks or VCR, distracting from the actual tested behaviour * performance during registration is not affected because of additional IO. A validation error on this aspect would manifest as a runtime error anyway, which is the same outcome as the remote API not accepting the configured options.
sergei-maertens
force-pushed
the
chore/4057-drop-gemma-zds-client
branch
from
17ea68d to
0e6e787
Compare
The updated validation would require adding more mocks to the existing tests, or instead, we can extend the fixture and use VCR for the Open Zaak API interaction.
Viicos
approved these changes
Mar 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4057