Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update dependencies to drop setuptools #3974

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 5, 2024

This is an experiment to see which dependencies relies on pkg_resources and does not use setuptools as a dependency. In Python 3.12, setuptools is no longer installed by default in venvs, and people used to rely on that to use pkg_resources (installed along with setuptools) to get the version of a package. By updating the last dependencies that used to rely on this (django-axes and josepy), setuptools will no longer be present, and I can then see what packages fail:

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (2b7b6b6) to head (fe7e7b3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3974   +/-   ##
=======================================
  Coverage   96.07%   96.08%           
=======================================
  Files         729      729           
  Lines       22980    22980           
  Branches     2674     2674           
=======================================
+ Hits        22078    22080    +2     
+ Misses        639      638    -1     
+ Partials      263      262    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the deps-setuptools branch from 40b6dad to 7e91f70 Compare March 6, 2024 10:00
@Viicos Viicos mentioned this pull request Mar 22, 2024
4 tasks
@Viicos Viicos requested review from sergei-maertens and removed request for sergei-maertens March 29, 2024 10:13
@Viicos Viicos marked this pull request as ready for review March 29, 2024 17:22
@sergei-maertens sergei-maertens merged commit bdf53af into master Mar 30, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the deps-setuptools branch March 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants