-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🦺 [#4057] Do not validate business logic during registration
Discussed with the team on Slack, extensive input validation where relations between configuration aspects are verified for consistency and integrity is required, but only during configuration of the form. At registration time itself, only the validations that don't touch external services are performed, so that: * tests are simpler to write without having to set up mocks or VCR, distracting from the actual tested behaviour * performance during registration is not affected because of additional IO. A validation error on this aspect would manifest as a runtime error anyway, which is the same outcome as the remote API not accepting the configured options.
- Loading branch information
1 parent
6ed79a6
commit 17ea68d
Showing
2 changed files
with
23 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters