Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Fix client-side errors in the playground frontend 58 - Milestone 0.5 #59

Merged

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 8, 2021

Playground: Fix client-side errors in the playground frontend 58 - Milestone 0.5

Description

This PR is for issue #58

  • remove 'key' prop from Example.tsx component
  • use 'noThrow' prop on reach router Redirect component
    Some notes on my submission can be found in the readme I made and placed in the submission folder HERE. I'm still investigating further optimizations, which I describe in the readme file, as well as my plan to submit a follow-up PR to this one which will add up to represent Milestone 1.

Submission Links & Documents

  • Readme file with details HERE.
  • PR made to the flow-playground repo HERE.

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes

@psiemens psiemens requested a review from MaxStalker October 11, 2021 05:53
@hichana hichana changed the title Playground: Fix client-side errors in the playground frontend #58 - Milestone #0.5 Playground: Fix client-side errors in the playground frontend 58 - Milestone 0.5 Oct 24, 2021
@MaxStalker MaxStalker merged commit e93487b into onflow:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants