Skip to content

Commit

Permalink
Merge pull request #59 from hichana/submission/issue-#58/milestone-#0…
Browse files Browse the repository at this point in the history
….5/hichana

Playground: Fix client-side errors in the playground frontend 58 - Milestone 0.5
  • Loading branch information
Maksim Daunarovich authored Oct 25, 2021
2 parents 921e661 + a69bc71 commit e93487b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions submission/issue-#58/milestone-#0.5/hichana/# milestone_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
### Milestone Readme
Thank you for reviewing my submission. I've designated this as a "#0.5" milestone because my solution resolves the errors in the console as required by the FLIP issue, but I'm still investigating how the project provider handles redirects via reach router. This might require refactoring, tho I'm not sure yet. For example, when loading the playground, 5 entries are added into the browser's history stack:

- http://localhost:3000/
- http://localhost:3000/local
- http://localhost:3000/LOCAL-project?type=account&id=LOCAL-account-0
- http://localhost:3000/?type=account&id=LOCAL-account-0
- http://localhost:3000/local?type=account&id=LOCAL-account-0

When I'm done looking into this further and if it turns out to be something that can be optimized, or if there are other related ways to optimize and/or refactor, I will make a second PR as milestone-#1 with the solution. Likewise, if it's fine the way it is then I will simply make a second PR as the milestone-#1 to complete my submission for this task.

The PR for the bug-fixes in the flow-playground repo can be found here: https://github.com/onflow/flow-playground/pull/167

0 comments on commit e93487b

Please sign in to comment.