Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Fix client-side errors in the playground frontend 58 - Milestone 0.5 #59

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions submission/issue-#58/milestone-#0.5/hichana/# milestone_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
### Milestone Readme
Thank you for reviewing my submission. I've designated this as a "#0.5" milestone because my solution resolves the errors in the console as required by the FLIP issue, but I'm still investigating how the project provider handles redirects via reach router. This might require refactoring, tho I'm not sure yet. For example, when loading the playground, 5 entries are added into the browser's history stack:

- http://localhost:3000/
- http://localhost:3000/local
- http://localhost:3000/LOCAL-project?type=account&id=LOCAL-account-0
- http://localhost:3000/?type=account&id=LOCAL-account-0
- http://localhost:3000/local?type=account&id=LOCAL-account-0

When I'm done looking into this further and if it turns out to be something that can be optimized, or if there are other related ways to optimize and/or refactor, I will make a second PR as milestone-#1 with the solution. Likewise, if it's fine the way it is then I will simply make a second PR as the milestone-#1 to complete my submission for this task.

The PR for the bug-fixes in the flow-playground repo can be found here: https://github.com/onflow/flow-playground/pull/167