Internal consensus mode of Inner Ring with Sidechain auto-deploy #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
12a4c5e to
c359432
Compare
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
2 times, most recently
from
5ee6a38 to
d80eab0
Compare
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
2 times, most recently
from
29cc462 to
f22a3bd
Compare
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
cthulhu-rider
requested review from
evgeniiz321,
MaxGelbakhiani and
vvarg229
https://github.com/vvarg229/neofs-node/actions/runs/7252535413/job/19757223163?pr=50 |
cthulhu-rider
commented
Dec 19, 2023
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
f22a3bd to
267fe52
Compare
bin/update_hosts.sh
Outdated
|
|
||
| # Get the line numbers of "Addresses:" | ||
| addresses_lines=$(grep -n "Addresses:" "$MORPH_CHAIN_CONFIG" | cut -d ':' -f 1) | ||
| # FIXME: grep by 'listen:' is unstable, jump to exact YAML fields |
There was a problem hiding this comment.
Likely can be fixed with some jq incantation.
There was a problem hiding this comment.
do you mind fixing this separately? the approach was the same before
There was a problem hiding this comment.
Likely can be fixed with some
jqincantation.
The jq is sometimes not installed on the custom runners.
There was a problem hiding this comment.
do you mind fixing this separately
Issue?
The jq is sometimes not installed
We already use it in scripts, so I doubt dev-env would work without it.
There was a problem hiding this comment.
@roman-khimov #302 (and #303)
vvarg229
previously approved these changes
Dec 20, 2023
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
267fe52 to
6a35b24
Compare
This was referenced Dec 20, 2023
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
6a35b24 to
d7473c6
Compare
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
d7473c6 to
78d41c9
Compare
`[email protected]` release gave us the opportunity to deploy/update the network automatically using IR. Moreover, starting from `@v0.36`, IR can be launched in internal consensus mode to avoid maintaining a separate NeoFS chain (IR becomes Neo blockchain itself). Using these features in DevEnv will significantly simplify its architecture. Significant changes check list: - upgrade all `neofs-node` apps to `@v0.39.1` (currently the latest) - configure `ir` service to be run in the local consensus mode - purge no longer needed `morph_chain` service - configure `ir` service to perform network auto-deployment - make `ir` service a bootstrap one to keep previous run flow - do not exec no longer needed `neofs-adm morph init` command (IR does all the stuff) - purge UN/LOCODE database that was embedded into IR in `@v0.39` - add healthcheck of the (main) `chain` service since it should be ready to accept deployed NeoFS contract - store NeoFS chain DB in the persistent volume so as not to deploy the network from scratch every time (the volume can be removed to reset) Closes #252. Closes #295. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/internal-consensus-with-autodeploy
branch
from
78d41c9 to
f54fdc7
Compare
vvarg229
approved these changes
Dec 21, 2023
roman-khimov
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pls have a look and advisable pull+try
i'll write commit message finally