ir: Do not configure network settings #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balance and Container contracts now depend on the Netmap one which is completely independent. Also reflect the current order in the file names of `contracts/` directory. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
|
deployment works with nspcc-dev/neofs-dev-env#282 but IR does not become healthy, will take a look UPD: there was smth with my checked that configurations are equal with removed $ neofs-cli -r s01.neofs.devenv:8080 -w ../devenv/wallets/wallet.json netmap netinfo
Epoch: 3
Network magic: [net 0x3c2d] 15405
Time per block: 1s
NeoFS network configuration (system)
Audit fee: 0
Storage price: 0
Container fee: 1000
Container alias fee: 500
EigenTrust alpha: 0.1
Number of EigenTrust iterations: 4
Epoch duration: 240
Inner Ring candidate fee: 0
Maximum object size: 67108864
Withdrawal fee: 0
Homomorphic hashing disabled: false
Maintenance mode allowed: false
NeoFS network configuration (other)
SystemDNS: 636f6e7461696e6572 |
cthulhu-rider
force-pushed
the
2660-network-settings-autocfg
branch
from
ad4333f to
cd54f2c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
- Coverage 30.43% 30.22% -0.21%
==========================================
Files 406 406
Lines 30068 30025 -43
==========================================
- Hits 9150 9074 -76
- Misses 20134 20171 +37
+ Partials 784 780 -4 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
2660-network-settings-autocfg
branch
from
cd54f2c to
6236b43
Compare
In v0.19.1 Balance contract uses epoch subscription mechanism requiring committee witness of the deployment transaction and allowance to call the Netmap contract. Container contract also needs to use this mechanism. Signed-off-by: Leonard Lyubich <[email protected]>
Starting from v0.19.1 NeoFS ID contract does not process extra deployment data. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
2660-network-settings-autocfg
branch
from
6236b43 to
ac357fb
Compare
Network settings configuration did not justify itself because used only when initializing the FS chain. Use default network settings during the FS chain auto-deployment (same ones used by the NeoFS ADM tool). Introduce `fschain_autodeploy` config flag that replaces mode tuning previously based on `network_settings` section presence. Closes #2660. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
2660-network-settings-autocfg
branch
from
ac357fb to
00176f2
Compare
roman-khimov
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.