-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try autoupdating the network #2650
Comments
@roman-khimov updating of the running env is a little bit tricky. Need some help with these 3 questions.
What is the proper way of updating storage nodes ? or is this a bug?
Also not sure why the balance went away somewhere, is it a bug, or do I need to do some refills here? |
|
@roman-khimov here is the detailed version of my upgrade test:
Here are logs from containers after IR upgrade: Not sure what else should I do here, and is it an expected result or not. But current upgrade steps don't work as is. |
This just means that you've got a new chain and this is exactly what should be avoided. You need to keep IR configuration with separated CNs. |
@roman-khimov without consensus parameters in an IR config there is no autoupdate (https://github.com/nspcc-dev/neofs-node/blob/master/pkg/innerring/innerring.go#L362), so contracts stay the same. When consensus parameters are specified - we get 2 chains |
@evgeniiz321 pls describe how do you check this? |
With this commit c134063, how the IR config should look like during the update procedure? Currently it asks me to provide 'consensus' block no matter what, otherwise:
With consensus block specified in config, i got this:
And an IR container is not starting. As a base I'm still using this cfg - https://github.com/nspcc-dev/neofs-dev-env/pull/282/files#diff-eef24f7a930f3188178bdd2772c784f8c5e1caa7453bc8d02856dabb18d8b4d5 You can check docker containers here - testsrv1.spb1.nspcc.ru, I left config as is (/home/ezayats/neofs-dev-env) |
u must configure either then, regardless of the consensus, network deployment is toggled via neofs-node/config/example/ir.yaml Lines 90 to 92 in c134063
seems like u wanna auto-deployment but |
@cthulhu-rider: but if it's |
yep, but then all contracts must be deployed in advance (which hasn't been done according to @evgeniiz321 pls share used config |
Inner Ring app requires either `morph.endpoints` or `morph.consensus` to be configured. Previously, when user forgot to set both sections, the app responded with: ``` invalid blockchain configuration: missing root section 'morph.consensus' ``` This could confuse the app user: maybe he wants the remote consensus, just set FS chain RPC endpoints incorrectly, why local consensus is required then? From now failure will be: ``` invalid consensus configuration: either 'morph.endpoints' or 'morph.consensus' must be configured ``` Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
These errors are user-facing. For example, when NNS contract is missing, from: ``` could not create RPC client: scope setup: InferHash: Unknown contract (-102) ``` to: ``` could not create RPC client: scope setup: resolve NNS contract address: Unknown contract (-102) ``` Other contracts' errors also made clearer. Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
|
@evgeniiz321 i dont see do u preset some file by |
I managed to successfully restart IR with fschain_autodeploy parameter (from scratch, used dev-env master, then updated IR cfg + image version), see updated config:
After dump-hashes I see new contracts versions (v0.19.1), however hashes are the same as before. Is it a bug? dump-hashes before update:
dump-hashes after update:
After update also managed to get written objects Logs from updated IR: |
Hashes won't change, that's expected and that's perfectly fine. |
Ok, we can close issue then. Autoupdating was successful. |
Inner Ring app requires either `morph.endpoints` or `morph.consensus` to be configured. Previously, when user forgot to set both sections, the app responded with: ``` invalid blockchain configuration: missing root section 'morph.consensus' ``` This could confuse the app user: maybe he wants the remote consensus, just set FS chain RPC endpoints incorrectly, why local consensus is required then? From now failure will be: ``` invalid consensus configuration: either 'morph.endpoints' or 'morph.consensus' must be configured ``` Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
These errors are user-facing. For example, when NNS contract is missing, from: ``` could not create RPC client: scope setup: InferHash: Unknown contract (-102) ``` to: ``` could not create RPC client: scope setup: resolve NNS contract address: Unknown contract (-102) ``` Other contracts' errors also made clearer. Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
Inner Ring app requires either `morph.endpoints` or `morph.consensus` to be configured. Previously, when user forgot to set both sections, the app responded with: ``` invalid blockchain configuration: missing root section 'morph.consensus' ``` This could confuse the app user: maybe he wants the remote consensus, just set FS chain RPC endpoints incorrectly, why local consensus is required then? From now failure will be: ``` invalid consensus configuration: either 'morph.endpoints' or 'morph.consensus' must be configured ``` Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
These errors are user-facing. For example, when NNS contract is missing, from: ``` could not create RPC client: scope setup: InferHash: Unknown contract (-102) ``` to: ``` could not create RPC client: scope setup: resolve NNS contract address: Unknown contract (-102) ``` Other contracts' errors also made clearer. Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
With #2642 solved we can try autoupdate functionality of the network:
neofs-adm morph dump-hashes
)The text was updated successfully, but these errors were encountered: