Add some Inner Ring UX improvements #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Dec 8, 2023
cthulhu-rider
commented
- inspired by Try autoupdating the network #2650
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
- Coverage 28.48% 28.48% -0.01%
==========================================
Files 413 413
Lines 31966 31977 +11
==========================================
+ Hits 9106 9109 +3
- Misses 22079 22087 +8
Partials 781 781 ☔ View full report in Codecov by Sentry. |
|
Looks legit. |
cthulhu-rider
force-pushed
the
ir-config
branch
from
e65d4a5 to
1ec45e1
Compare
In 1a5bb64 `endpoint.client` section was replaced by `endpoints` but `consensus` continued to refer the old one. Also mention local consensus option in the `morph.endpoints` itself. Signed-off-by: Leonard Lyubich <[email protected]>
Inner Ring app requires either `morph.endpoints` or `morph.consensus` to be configured. Previously, when user forgot to set both sections, the app responded with: ``` invalid blockchain configuration: missing root section 'morph.consensus' ``` This could confuse the app user: maybe he wants the remote consensus, just set FS chain RPC endpoints incorrectly, why local consensus is required then? From now failure will be: ``` invalid consensus configuration: either 'morph.endpoints' or 'morph.consensus' must be configured ``` Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
These errors are user-facing. For example, when NNS contract is missing, from: ``` could not create RPC client: scope setup: InferHash: Unknown contract (-102) ``` to: ``` could not create RPC client: scope setup: resolve NNS contract address: Unknown contract (-102) ``` Other contracts' errors also made clearer. Refs #2650. Signed-off-by: Leonard Lyubich <[email protected]>
It's better to observe what's going on, especially with funds. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
ir-config
branch
from
1ec45e1 to
12f95f2
Compare
carpawell
approved these changes
Jan 17, 2024
| } | ||
| cntHash, err := nnsReader.ResolveFSContract(nns.NameContainer) | ||
| if err != nil { | ||
| return fmt.Errorf("resolving container: %w", err) | ||
| return fmt.Errorf("resolve Container contract address by NNS domain name %q: %w", nns.NameContainer, err) |
There was a problem hiding this comment.
"NNS domain name" confuses me. seems like it is about some ".nns"
There was a problem hiding this comment.
not sure i got ur point, pls write message text u suggest
roman-khimov
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.