Enable global element api to accept element properties as argument. #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
garg3133
reviewed
Jul 27, 2023
garg3133
reviewed
Aug 7, 2023
garg3133
reviewed
Aug 7, 2023
garg3133
reviewed
Aug 9, 2023
|
While the changes in this PR look good, the sample test mentioned in the original issue is still not working (it always returns the first matched element instead of the element on index 24). It seems that the index property is never taken into consideration when finding the element. |
garg3133
reviewed
Aug 9, 2023
yashPratp983
force-pushed
the
global-element-api
branch
from
125d607
to
b6de5d5
Compare
garg3133
reviewed
Aug 11, 2023
garg3133
reviewed
Aug 11, 2023
garg3133
reviewed
Aug 11, 2023
garg3133
approved these changes
Aug 14, 2023
gravityvi
requested changes
Aug 21, 2023
lib/api/_loaders/element-global.js
Outdated
| @@ -111,7 +128,7 @@ class ElementGlobal { | |||
| abortOnFailure, retryInterval, timeout, suppressNotFoundErrors, index | |||
| } = element; | |||
|
|
|||
| if (isDefined(index)) { | |||
| if (isDefined(index) && isNumber(index)) { | |||
There was a problem hiding this comment.
add an additional check for NaN
gravityvi
reviewed
Aug 21, 2023
lib/api/_loaders/element-global.js
Outdated
| if (locator instanceof Element) { | ||
| this.setPropertiesFromElement(locator); | ||
|
|
||
| locator = Locator.create(locator); |
There was a problem hiding this comment.
There are multiple calls to Locator.create. We should refactor this module and everything should be handled in setLocator method.
|
Any updates on this? |
…t from findElement to setLocator method
@gravityvi some tests are failing.Please help me out. |
|
the global element api will be deprecated and replaced by the new browser.element apis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables global elment api to accept element properties as argument.