Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable global element api to accept element properties as argument. #3835

Closed
wants to merge 17 commits into from
Closed

Enable global element api to accept element properties as argument. #3835

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5f87d1d
enabled global element api to accept element properties as argument
yashPratp983 Jul 27, 2023
d45e64f
fixed global element api to work with element properties as argument
yashPratp983 Aug 7, 2023
14d51fe
Linting fix
garg3133 Aug 8, 2023
b15e01f
added test for global element api to accept element property as argument
yashPratp983 Aug 9, 2023
d0f988a
Merge branch 'global-element-api' of https://github.com/yashPratp983/…
yashPratp983 Aug 9, 2023
125d607
set the output to false for the tests of element api
yashPratp983 Aug 9, 2023
5050d29
enabled global element api to accept element properties as argument
yashPratp983 Jul 27, 2023
2420d96
fixed global element api to work with element properties as argument
yashPratp983 Aug 7, 2023
9e8100b
added test for global element api to accept element property as argument
yashPratp983 Aug 9, 2023
1609771
Linting fix
garg3133 Aug 8, 2023
33476a7
set the output to false for the tests of element api
yashPratp983 Aug 9, 2023
b6de5d5
made element api to return the web element at the provided index
yashPratp983 Aug 11, 2023
7e161b8
refactored code of findElement() in element-global.js file
yashPratp983 Aug 11, 2023
1633f8e
refactored code of findElement() in element-global.js file
yashPratp983 Aug 11, 2023
d7194dd
made element api to return the web element at the provided index
yashPratp983 Aug 11, 2023
2f42697
refactored the way of checking the type of index from using typeof to…
yashPratp983 Aug 12, 2023
5d6c169
moved condition for handling for an element having instance of Elemen…
yashPratp983 Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/api/_loaders/element-global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ class ElementGlobal {
return;
}

this.element = await this.transport.driver.wait(until.elementLocated(locator), this.timeout, null, this.retryInterval);
const byLocator=Locator.create(locator);
garg3133 marked this conversation as resolved.
Show resolved Hide resolved

this.element = await this.transport.driver.wait(until.elementLocated(byLocator), this.timeout, null, this.retryInterval);
garg3133 marked this conversation as resolved.
Show resolved Hide resolved
}

static isElementObject(element) {
Expand Down
Loading