-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable global element api to accept element properties as argument. #3835
Closed
Closed
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5f87d1d
enabled global element api to accept element properties as argument
yashPratp983 d45e64f
fixed global element api to work with element properties as argument
yashPratp983 14d51fe
Linting fix
garg3133 b15e01f
added test for global element api to accept element property as argument
yashPratp983 d0f988a
Merge branch 'global-element-api' of https://github.com/yashPratp983/…
yashPratp983 125d607
set the output to false for the tests of element api
yashPratp983 5050d29
enabled global element api to accept element properties as argument
yashPratp983 2420d96
fixed global element api to work with element properties as argument
yashPratp983 9e8100b
added test for global element api to accept element property as argument
yashPratp983 1609771
Linting fix
garg3133 33476a7
set the output to false for the tests of element api
yashPratp983 b6de5d5
made element api to return the web element at the provided index
yashPratp983 7e161b8
refactored code of findElement() in element-global.js file
yashPratp983 1633f8e
refactored code of findElement() in element-global.js file
yashPratp983 d7194dd
made element api to return the web element at the provided index
yashPratp983 2f42697
refactored the way of checking the type of index from using typeof to…
yashPratp983 5d6c169
moved condition for handling for an element having instance of Elemen…
yashPratp983 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple calls to
Locator.create
. We should refactor this module and everything should be handled insetLocator
method.