Fix properties not being displayed (needs testing)

[j-maas]

This should fix #3440.

When opening a contact with custom labels as in the issue, I noticed the following error message in the console:

TypeError: this.properties[this.property.name] is undefined
    isMultiple ContactDetailsProperty.vue:136
    VueJS 3
    jN ContactDetailsProperty.vue:5
    render vue-composition-api.common.prod.js:1
    Qe vue-composition-api.common.prod.js:1
    render vue-composition-api.common.prod.js:1
    VueJS 32
    r ContactDetails.vue:805
    c isTalkEnabled.js:25
    y isTalkEnabled.js:25
    b isTalkEnabled.js:25
    eR isTalkEnabled.js:25
    o isTalkEnabled.js:25
    promise callback*eR isTalkEnabled.js:25
    o isTalkEnabled.js:25
    promise callback*eR isTalkEnabled.js:25
    o isTalkEnabled.js:25
    tR isTalkEnabled.js:25
    tR isTalkEnabled.js:25
    selectContact ContactDetails.vue:770
    contact ContactDetails.vue:684
    VueJS 11
    init vue-router.esm.js:3005
    init vue-router.esm.js:3004
    updateRoute vue-router.esm.js:2414
    transitionTo vue-router.esm.js:2263
    confirmTransition vue-router.esm.js:2402
    r vue-router.esm.js:2084
    Qe vue-router.esm.js:2095
    confirmTransition vue-router.esm.js:2396
    r vue-router.esm.js:2084
    r vue-router.esm.js:2088
    g vue-router.esm.js:2384
    Ke vue-router.esm.js:2162
    g vue-router.esm.js:2362
    r vue-router.esm.js:2087
    r vue-router.esm.js:2091
    r vue-router.esm.js:2091
    Qe vue-router.esm.js:2095
    confirmTransition vue-router.esm.js:2392
    transitionTo vue-router.esm.js:2260
    push vue-router.esm.js:2606
    push vue-router.esm.js:3039
    _ vue-router.esm.js:1139
    onClick index.module.js:2

Since in PR #2064 there was a similar issue in another method, I suspect that the same fix can be applied here.

However, I was unfortunately not able to test this change, since I don't have a full development setup and I couldn't hack it in the browser. So you need to test that this fix is correct.

[kesselb]

Looks good to me 👍

https://www.rfc-editor.org/rfc/rfc6352#section-10.4.2
https://www.rfc-editor.org/rfc/rfc6350#section-3.3

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (38db5d0) 1.81% compared to head (00de88b) 2.07%.
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3644      +/-   ##
==========================================
+ Coverage     1.81%   2.07%   +0.26%     
==========================================
  Files          113      89      -24     
  Lines         6130    5354     -776     
  Branches      1491    1492       +1     
==========================================
  Hits           111     111              
+ Misses        5901    5125     -776     
  Partials       118     118              

Files	Coverage Δ
...mponents/ContactDetails/ContactDetailsProperty.vue	0.00% <ø> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[j-maas]

@kesselb I'm a bit overwhelmed with what exactly to do. If you tell me what to do, I might try, but I currently don't have much time to dig in.

So if you're dependent on me doing something, it might be easier to open a new PR... I hope that's ok with you.

[st3iny]

I simplified the code even further.

@j-maas Thank you for the PR.

[st3iny]

Tested and works.

[st3iny]

/backport to stable5.4

[j-maas]

Thanks for taking this on! ❤️

[DiagonalArg]

Where should we see this? I'm on 5.5.0, everything updated, and I'm still getting addresses rendered improperly, as here: #3736 (comment)

[st3iny]

@DiagonalArg This fix is about missing props in our frontend. Please open a new issue.