Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemN.* not Imported into NC Via Web; "," Escaped in Notes; ":" in Address Throws Errors #3736

Closed
DiagonalArg opened this issue Dec 10, 2023 · 6 comments
Labels

Comments

@DiagonalArg
Copy link

DiagonalArg commented Dec 10, 2023

Describe the bug

Export a test vCard from Google Contacts (iOS format). Import to Nextcloud Contacts via web interface. See that none of the itemN.* attributes are imported and that some characters in Notes are escaped.

Steps to reproduce

Import this card:

BEGIN:VCARD
VERSION:3.0
FN:J & N Test
N:Test;J & N;;;
item1.TEL:+1.555 222 4444
item1.X-ABLabel:J Cell
item2.TEL:+1.555 444 8888
item2.X-ABLabel:J Cell Pix
item3.TEL:+1.888 555 2222
item3.X-ABLabel:N Cell
item4.TEL:+1.999 555 9999
item4.X-ABLabel:Old Cell
NOTE:A\, b. 2023.
CATEGORIES:myContacts
END:VCARD

J&N.Test.txt

Expected behavior

I should see the phone numbers with their labels. I should also see notes without characters like "," being escaped.

Actual behavior

Get this results:

image

Contact version

5.4.2

Operating system

CentOS 7.8.2003

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database

PostgreSQL

Additional info

Nextcloud version 27.14

@DiagonalArg
Copy link
Author

DiagonalArg commented Dec 10, 2023

I can confirm that as also reported, here, it's also failing to import addresses. Another vcard, which I imported to Nextcloud. See the result, below that.

BEGIN:VCARD
VERSION:3.0
FN:R M D
N:D;R M;;;
item1.ADR:;;121 South Estes Dr.;Chapel Hill;NC;27514;US;121 South Estes Dr.
\nChapel Hill, NC 27514\nUS
item1.X-ABLabel:
CATEGORIES:myContacts
END:VCARD

RMD.Stripped.txt

image

@DiagonalArg DiagonalArg changed the title itemN.* not imported into nextcloud webinterface; characters escaped in notes itemN.* not Imported into NC Web; "," Escaped in Notes; ":" in Address Throws Errors Dec 10, 2023
@DiagonalArg
Copy link
Author

Finally, when there is a ":" in the address, import to NC throws an error.

BEGIN:VCARD
VERSION:3.0
FN:R M D
N:D;R M;;;
item1.ADR:;;Dorchester Village: CenterPoint;;NC;;US;Dorchester Village: C
enterPoint\nNC\nUS
item1.X-ABLabel:
CATEGORIES:myContacts
END:VCARD

RMD.txt

@DiagonalArg DiagonalArg changed the title itemN.* not Imported into NC Web; "," Escaped in Notes; ":" in Address Throws Errors itemN.* not Imported into NC Via Web; "," Escaped in Notes; ":" in Address Throws Errors Dec 10, 2023
@DiagonalArg
Copy link
Author

On upgrade to 5.5.0, I can now see the itemN.X-ABLabel's for phone numbers and addresses, but many addresses are showing up like this:

";;1025 Keeler Ave;Berkeley;CA;94708-140 ..."

@hamza221
Copy link
Contributor

duplicate of #3721

@hamza221 hamza221 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@hamza221
Copy link
Contributor

hamza221 commented Dec 19, 2023

Fixes in #3644, releasing soon

@DiagonalArg
Copy link
Author

Address issue not repaired in 5.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants