Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.4] Fix properties not being displayed (needs testing) #3660

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #3644

@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Oct 16, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the v5.4.3 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (stable5.4@bb749ca). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             stable5.4   #3660   +/-   ##
===========================================
  Coverage             ?   2.07%           
===========================================
  Files                ?      89           
  Lines                ?    5354           
  Branches             ?    1492           
===========================================
  Hits                 ?     111           
  Misses               ?    5125           
  Partials             ?     118           
Files Coverage Δ
...mponents/ContactDetails/ContactDetailsProperty.vue 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny force-pushed the backport/3644/stable5.4 branch from 34578fe to 99599f2 Compare October 16, 2023 10:11
@st3iny
Copy link
Member

st3iny commented Oct 16, 2023

Amended the commit to fix DCO.

@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 16, 2023
@st3iny st3iny merged commit 6d8494d into stable5.4 Oct 16, 2023
26 checks passed
@st3iny st3iny deleted the backport/3644/stable5.4 branch October 16, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants