-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODEL] Model basic pipeline availability info in imaging session #347
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 98.06% 98.08% +0.01%
==========================================
Files 13 13
Lines 775 782 +7
==========================================
+ Hits 760 767 +7
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11043913553Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @alyssadai. I have only one change suggestion. Take a look and then we can go
Co-authored-by: Sebastian Urchs <[email protected]>
Co-authored-by: Sebastian Urchs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🧑🍳
🚀 PR was released in |
Changes proposed in this pull request:
hasAcquisition
turned into optional property, to account for imaging sessions that only have pipeline/derivative data attachedChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: