Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODEL] Model basic pipeline availability info in imaging session #347

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 25, 2024

Changes proposed in this pull request:

  • Add info about availability of a completed pipeline run, pipeline name, and pipeline version to the imaging session model
  • hasAcquisition turned into optional property, to account for imaging sessions that only have pipeline/derivative data attached

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (d263547) to head (e9afaa6).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   98.06%   98.08%   +0.01%     
==========================================
  Files          13       13              
  Lines         775      782       +7     
==========================================
+ Hits          760      767       +7     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyssadai alyssadai changed the title Model pipeline info [MODEL] Model basic pipeline availability info in imaging session Sep 25, 2024
@alyssadai alyssadai added the pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) label Sep 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11043913553

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.082%

Totals Coverage Status
Change from base Build 10686168321: 0.02%
Covered Lines: 767
Relevant Lines: 782

💛 - Coveralls

@alyssadai alyssadai requested a review from surchs September 25, 2024 19:11
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @alyssadai. I have only one change suggestion. Take a look and then we can go

bagel/models.py Outdated Show resolved Hide resolved
bagel/models.py Outdated Show resolved Hide resolved
bagel/models.py Outdated Show resolved Hide resolved
alyssadai and others added 3 commits September 25, 2024 21:30
Co-authored-by: Sebastian Urchs <[email protected]>
Co-authored-by: Sebastian Urchs <[email protected]>
@alyssadai alyssadai requested a review from surchs September 26, 2024 01:32
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🧑‍🍳

@alyssadai alyssadai merged commit da72256 into main Sep 26, 2024
11 checks passed
@alyssadai alyssadai deleted the model-pipeline-info branch September 26, 2024 01:51
Copy link
Contributor

🚀 PR was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update graph data model
3 participants