-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSTORE-1461] Refactor Kafka out of python engine #1359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine/test_python.py
and test_feature_group_writer.py
should be fixed. They fail attempting to mock _init_kafka_resources
and _init_kafka_consumer
at the moment. Should be enough to change hsfs.engine.python.Engine._init_kafka_resources
and hsfs.engine.python.Engine._init_kafka_consumer
in mocks to hsfs.core.kafka_engine.init_kafka_resources
and hsfs.core.kafka_engine.init_kafka_consumer
.
This PR adds/fixes/changes...
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: