Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1461] Refactor Kafka out of python engine #1359

Merged
merged 16 commits into from
Jul 8, 2024

Conversation

vatj
Copy link
Contributor

@vatj vatj commented Jul 4, 2024

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@vatj vatj requested a review from aversey July 5, 2024 08:27
Copy link
Contributor

@aversey aversey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine/test_python.py and test_feature_group_writer.py should be fixed. They fail attempting to mock _init_kafka_resources and _init_kafka_consumer at the moment. Should be enough to change hsfs.engine.python.Engine._init_kafka_resources and hsfs.engine.python.Engine._init_kafka_consumer in mocks to hsfs.core.kafka_engine.init_kafka_resources and hsfs.core.kafka_engine.init_kafka_consumer.

@vatj vatj merged commit 834d13f into logicalclocks:master Jul 8, 2024
13 checks passed
@vatj vatj deleted the FSTORE-1461 branch July 8, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants