Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(client): use transmitResultPool to reduce heap allocs #722

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Feb 25, 2024

WIP

@ijsong ijsong self-assigned this Feb 25, 2024
@ijsong ijsong marked this pull request as draft February 25, 2024 13:07
@ijsong ijsong force-pushed the perf_transmitResultPool branch from b2ae65b to a79d3c1 Compare February 25, 2024 13:15
@ijsong ijsong force-pushed the perf_transmitResultPool branch from a79d3c1 to d04339e Compare February 25, 2024 14:54
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 49.63%. Comparing base (2bd0a62) to head (94fad3a).

Files Patch % Lines
pkg/varlog/subscribe.go 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   49.72%   49.63%   -0.10%     
==========================================
  Files         235      235              
  Lines       20725    20731       +6     
==========================================
- Hits        10305    10289      -16     
- Misses       9780     9797      +17     
- Partials      640      645       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the perf_pq_prealloc branch from 1e93669 to 43ba3be Compare March 5, 2024 07:02
@ijsong ijsong force-pushed the perf_transmitResultPool branch from 728cdc3 to 7219cc8 Compare March 5, 2024 07:02
@ijsong ijsong force-pushed the perf_pq_prealloc branch from 43ba3be to 58a5c21 Compare March 5, 2024 09:58
Base automatically changed from perf_pq_prealloc to main March 5, 2024 11:03
@ijsong ijsong force-pushed the perf_transmitResultPool branch from 7219cc8 to aa40aec Compare March 5, 2024 11:18
Struct pkg/varlog.(transmitResult) is an element of transmitQueue. It is
allocated in heap memory to be pushed into transmitQueue. This PR introduces
transmitResultPool to reuse transmitResult as possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant