Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmark): refine the benchmark tool for log subscription #716

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Feb 25, 2024

What this PR does

This update fixes the benchmark tool, enabling it to subscribe to all logs from
specified a topic or a log stream. It introduces a mechanism where a loader
fetches logs, with the number of logs defined by the "--subscribe-size" CLI
flag.

@ijsong ijsong requested a review from hungryjang as a code owner February 25, 2024 12:50
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 19.16667% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 49.80%. Comparing base (9f9401c) to head (9199784).
Report is 2 commits behind head on main.

❗ Current head 9199784 differs from pull request most recent head 01bf188. Consider uploading reports for the commit 01bf188 to get more accurate results

Files Patch % Lines
internal/benchmark/loader.go 0.00% 82 Missing ⚠️
internal/storage/scanner.go 71.87% 6 Missing and 3 partials ⚠️
internal/benchmark/benchmark.go 0.00% 4 Missing ⚠️
cmd/benchmark/test_command.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   49.78%   49.80%   +0.02%     
==========================================
  Files         235      235              
  Lines       20651    20704      +53     
==========================================
+ Hits        10281    10312      +31     
- Misses       9730     9758      +28     
+ Partials      640      634       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong self-assigned this Feb 25, 2024
@ijsong ijsong force-pushed the perf_storage_scanwithglsn branch from 670d854 to e0ef909 Compare February 26, 2024 14:36
@ijsong ijsong force-pushed the fix_benchmark_subscribe_rpc branch from 17905f3 to 9199784 Compare February 26, 2024 14:43
@ijsong
Copy link
Member Author

ijsong commented Feb 26, 2024

Merge activity

  • Feb 26, 10:00 AM EST: @ijsong started a stack merge that includes this pull request via Graphite.
  • Feb 26, 10:09 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 26, 10:17 AM EST: @ijsong merged this pull request with Graphite.

@ijsong ijsong force-pushed the perf_storage_scanwithglsn branch from e0ef909 to 963d10f Compare February 26, 2024 15:00
Base automatically changed from perf_storage_scanwithglsn to main February 26, 2024 15:08
This update fixes the benchmark tool, enabling it to subscribe to all logs from
specified a topic or a log stream. It introduces a mechanism where a loader
fetches logs, with the number of logs defined by the "--subscribe-size" CLI
flag.
@ijsong ijsong force-pushed the fix_benchmark_subscribe_rpc branch from 9199784 to 01bf188 Compare February 26, 2024 15:09
@ijsong ijsong merged commit eb83d42 into main Feb 26, 2024
9 checks passed
@ijsong ijsong deleted the fix_benchmark_subscribe_rpc branch February 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants