Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): add benchmark for scanning with GLSN #714

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Feb 22, 2024

What this PR does

This PR introduces a new benchmark, BenchmarkStorage_ScanWithGLSN, to measure
storage performance when scanning with GLSN across various scan sizes. The
benchmark will serve as foundational data for performance optimization efforts.

Changes:

  • Implemented the BenchmarkStorage_ScanWithGLSN benchmark
  • Added logic to measure performance across different scan sizes
  • Laid groundwork for recording and analyzing performance measurement results

@ijsong ijsong requested a review from hungryjang as a code owner February 22, 2024 16:34
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.79%. Comparing base (b7fa615) to head (2fb6b53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   49.80%   49.79%   -0.01%     
==========================================
  Files         235      235              
  Lines       20651    20651              
==========================================
- Hits        10286    10284       -2     
+ Misses       9732     9729       -3     
- Partials      633      638       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This PR introduces a new benchmark, BenchmarkStorage_ScanWithGLSN, to measure
storage performance when scanning with GLSN across various scan sizes. The
benchmark will serve as foundational data for performance optimization efforts.

Changes:
- Implemented the BenchmarkStorage_ScanWithGLSN benchmark
- Added logic to measure performance across different scan sizes
- Laid groundwork for recording and analyzing performance measurement results
@ijsong ijsong force-pushed the benchmark_storage_scanwithglsn branch from cdaa7ac to 2fb6b53 Compare February 26, 2024 14:27
@ijsong
Copy link
Member Author

ijsong commented Feb 26, 2024

Merge activity

  • Feb 26, 10:00 AM EST: @ijsong started a stack merge that includes this pull request via Graphite.
  • Feb 26, 10:00 AM EST: @ijsong merged this pull request with Graphite.

@ijsong ijsong merged commit 9f9401c into main Feb 26, 2024
11 checks passed
@ijsong ijsong deleted the benchmark_storage_scanwithglsn branch February 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants