Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on pr2-common (pr2_mechanism_model) for euscollada conversion test #46

Merged

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Jun 9, 2014

Add dependency on pr2-common (pr2_mechanism_model) for euscollada conversion test.

After this commit, jsk_model_tools travis should be fail until Euslisp deb release.
This means jsk_model_tools's travis successfully trap Euslisp version violation.

Related PR or issues:

@snozawa
Copy link
Contributor Author

snozawa commented Jun 9, 2014

Unfortunately, travis passed.
This travis should fail because I add codes to trap Euslisp deb mismatching.
I'll check the log.

@snozawa
Copy link
Contributor Author

snozawa commented Jun 9, 2014

Travis unintentionally succeeded.
I'll fix again.

Now I'm checking whether the test for rosbuild and DEB=true environment fails or not.
The latest jsk_model_tools is for the latest Euslisp source.
So, the latest jsk_model_tools should fail for deb and non-latest Euslisp binary.
I'd like to trap this Euslisp deb mismatching in travis, especially in rosbuild and DEB=true environment.

@k-okada
Copy link
Member

k-okada commented Jun 10, 2014

it fails with follows even if DEB=false, is this correct?

eustf roseus_c_util
/home/k-okada/ros/groovy/jsk-ros-pkg/jsk_roseus/euslisp/jskeus/eus/Linux64/bin/irteusgl:
ERROR th=0 cannot find method
:make-collision-model-for-links:make-collision-model-for-links in (send
self :make-collision-model-for-links)E: (exit)

On Tue, Jun 10, 2014 at 5:01 AM, Shunichi Nozawa [email protected]
wrote:

Travis unintentionally succeeded.
I'll fix again.

Now I'm checking whether the test for rosbuild and DEB=true environment
fails or not.
The latest jsk_model_tools is for the latest Euslisp source.
So, the latest jsk_model_tools should fail for deb and non-latest Euslisp
binary.
I'd like trap this Euslisp deb mismatching in travis, especially in
rosbuild and DEB=true environment.


Reply to this email directly or view it on GitHub
#46 (comment)
.

@snozawa
Copy link
Contributor Author

snozawa commented Jun 10, 2014

  • About reading travis log

    it fails with follows even if DEB=false, is this correct?

    No, it is not correct.
    DEB=false should success.
    I'll check this problem.
    How do you read the above-mentioned log??
    Can I read the log file within travis log?

    /home/travis/.ros/rosmake/rosmake_output-20140609-200125/euscollada/build_output.log
    
  • About Euslisp error handling in tests
    In general, I think it would be better to use unittest.l in euslisp test ran in travis, rosbuild, or catkin,... etc.
    Currently, we call Euslisp test directly.
    if Euslisp error occurs, Euslisp test in rosbuild stops and it takes more than 50 minutes to finish test.
    By using unittest.l in Euslisp test, if Euslisp error occurs, Euslisp test exits with return code 1 and
    we do not need to wait 50 minutes.

  • About others
    In addition, related questions:
    821ec51
    41e019f#diff-374af3ba6a2d4bf28c9c04492a045280R75

@k-okada
Copy link
Member

k-okada commented Jun 10, 2014

i just test in my local machine. it hard to read travis log in timeout case. run roseus with unittest mode will exit when fail

@snozawa
Copy link
Contributor Author

snozawa commented Jun 10, 2014

Currently I finished to update commit, e.g.,
if DEB=true and rosbuild, travis failed,
otherwise, travis success.

I'll fix and rearrange commit.

…model to travis.yaml ;; Fix cmake and use unittest.l in pr2.sh to trap Euslisp error
@snozawa
Copy link
Contributor Author

snozawa commented Jun 10, 2014

I think this PR is ready to be merged.

After that,

  1. After merging this PR, jsk_model_tools's travis will fail (successfully trapping of Euslisp deb mismatching).
  2. I revert the PR(move codes for collision model from euscollada-robot*.l euslisp/jskeus#93) because the PR is invalid. I'll just move :make-collision-xxxx from irtrobot.l to original euscollada-robot.l. At this time, jsk_model_tools's travis will return to normal (success).
  3. I'll create CHANGELOG.rst for euslisp according to release jsk_roseus jsk_roseus#110
  4. In order to move :make-collision-xxx codes, I'll continue discussing in Move codes in euscollada-robot.l to irteus #41.

@k-okada
Copy link
Member

k-okada commented Jun 10, 2014

I think this PR is ready to be merged.

merge this script after we confirm this PR passed the travis with newer jsk_roseus release package. merging failed PR is basically not good.

@snozawa
Copy link
Contributor Author

snozawa commented Jun 10, 2014

Thank you for your comment.

  1. I revert the PR(move codes for collision model from euscollada-robot*.l euslisp/jskeus#93) because the PR is invalid. I'll just move :make-collision-xxxx from irtrobot.l to original euscollada-robot.l. At this time, jsk_model_tools's travis will return to normal (success).
  2. I'll create CHANGELOG.rst for euslisp according to release jsk_roseus jsk_roseus#110

I'll try this reverting, creating change log, and releasing first.
After that, I'll announce again.

@snozawa
Copy link
Contributor Author

snozawa commented Jun 12, 2014

Travis passed under the latest Euslisp deb.
(I restarted travis many times because travis somtimes failed in apt-key error...)

I also confirmed the latest Euslisp deb by travis log message:

Get:4 http://packages.ros.org/ros-shadow-fixed/ubuntu/ precise/main ros-groovy-euslisp amd64 1.1.19-0precise-20140611-0637-+0000 [12.4 MB]

This PR is related with jsk-ros-pkg/jsk_roseus#114.

snozawa added a commit that referenced this pull request Jun 12, 2014
@snozawa snozawa merged commit ddbb397 into jsk-ros-pkg:master Jun 12, 2014
k-okada pushed a commit to euslisp/EusLisp that referenced this pull request Feb 9, 2015
aginika pushed a commit to aginika/jsk_model_tools that referenced this pull request Jul 30, 2015
…-for-rviz-remote

add downsampled pointcloud for visualization on rviz on remote machine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants