make java-version an input #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Jun 15, 2022
| @@ -53,11 +59,11 @@ jobs: | |||
| with: | |||
| fetch-depth: 0 | |||
|
|
|||
| - name: Set up JDK 8 | |||
| - name: Set up JDK ${{ inputs.java-version }} | |||
There was a problem hiding this comment.
Once we have plugins start to pick up post-switch core versions, if any overrode this to say 8, their releases would start to break.
Fine #11 wins 😅
|
I guess we just pay attention to whether there are any serious issues with releasing from JDK 11. So far I have heard about one relatively minor bug in Javadoc; and a Javadoc frameless mode which some people like and some people dislike (but the opinion of the plugin maintainer is not particularly relevant since they are unlikely to be the ones viewing their own Javadoc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.