Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK setup step name was too specific and incorrect #11

Merged
merged 1 commit into from
Jun 15, 2022
Merged

JDK setup step name was too specific and incorrect #11

merged 1 commit into from
Jun 15, 2022

Conversation

jglick
Copy link
Collaborator

@jglick jglick commented Jun 15, 2022

@jglick jglick requested a review from jetersen June 15, 2022 18:01
@jglick jglick added bug Something isn't working chore and removed chore labels Jun 15, 2022
@jglick
Copy link
Collaborator Author

jglick commented Jun 15, 2022

(Trivial but technically a bug since this appears in the action run UI.)

@jetersen
Copy link
Collaborator

I prefer #10 that way it is shown in the action title which version is used.

@jglick jglick mentioned this pull request Jun 15, 2022
Closed
@jetersen jetersen merged commit 3ac7ddc into main Jun 15, 2022
@jetersen jetersen deleted the jglick-patch-1 branch June 15, 2022 18:13
@jglick jglick mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @jetersen