Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make java-version an input #10

Closed
wants to merge 1 commit into from
Closed

make java-version an input #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/maven-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ on:
MAVEN_TOKEN:
required: true
description: Maven token used for deploying the plugin jar to Jenkins Artifactory Repository
inputs:
java-version:
required: false
default: '11'
description: The Java version to set up. Takes a whole or semver Java version. See examples of supported syntax in the actions/setup-java README file # https://github.com/actions/setup-java#supported-version-syntax
type: string

jobs:
validate:
Expand Down Expand Up @@ -53,11 +59,11 @@ jobs:
with:
fetch-depth: 0

- name: Set up JDK 8
- name: Set up JDK ${{ inputs.java-version }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just #11

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have plugins start to pick up post-switch core versions, if any overrode this to say 8, their releases would start to break.

Fine #11 wins 😅

uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 11
java-version: ${{ inputs.java-version }}

- name: Release
uses: jenkins-infra/[email protected]
Expand Down