Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to text selector #81060

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

steverep
Copy link
Member

@steverep steverep commented Oct 27, 2022

Proposed change

This allows text selectors to use the HTML autocomplete attribute, which controls browser autofill capabilities for username, password, name, address, etc.

This is already supported in the frontend:

This just completes the work by adding to blueprint and config flow capabilities. The ability to support password managers has been a widely requested feature in the frontend on GitHub and WTH.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@steverep
Copy link
Member Author

Thanks for the reviews @bdraco!

@bdraco bdraco merged commit c940ad9 into home-assistant:dev Nov 15, 2022
@steverep steverep deleted the text-selector-autocomplete branch November 15, 2022 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core Hacktoberfest hacktoberfest-accepted new-feature parent-merged small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants