Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autofill to data entry flow #1528

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Add Autofill to data entry flow #1528

merged 8 commits into from
Nov 15, 2022

Conversation

steverep
Copy link
Member

Proposed change

Documents how integration authors can enable browser autofill in their data entry flows. Requires merging home-assistant/core#81060.

Because it didn't really fit well into the existing doc, I took the liberty of rearranging the "Show Form" section and organizing into sub-headings. I think it reads more clearly now.

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

@bdraco
Copy link
Member

bdraco commented Nov 15, 2022

It would be easier to review this if it was split into multiple PRs

@steverep
Copy link
Member Author

If you look at the 2 commits separately it's probably a lot easier to review. The first just literally moves text around to avoid repetition about translations and add sub-sections. And then I organized the keys into a small table. There's no real new text.

The second adds the new autofill section.

You're right though. I probably would have split it up if I wrote it in that order. 🙃

Co-authored-by: J. Nick Koston <[email protected]>
@steverep steverep requested a review from bdraco November 15, 2022 16:43
@bdraco bdraco merged commit e95eef1 into master Nov 15, 2022
@bdraco bdraco deleted the autofill-data-entry-flow branch November 15, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants